Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dedupe signature #730

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Refactor dedupe signature #730

merged 4 commits into from
Jun 17, 2024

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Jun 17, 2024

We only need includeArtieUpdatedAt, we don't need to pass in the whole kafkalib.TopicConfig

@Tang8330 Tang8330 marked this pull request as ready for review June 17, 2024 18:11
Copy link
Contributor

@nathan-artie nathan-artie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Tang8330 Tang8330 merged commit 61b279c into master Jun 17, 2024
1 check passed
@Tang8330 Tang8330 deleted the refactor-dedupe-signature branch June 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants