Add batch.BySize function
#735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tang8330
reviewed
Jun 17, 2024
lib/batch/batch.go
Outdated
|
|
||
| // BySize takes a series of elements, encodes them, groups them into batches of bytes that sum to at most [maxSize], and | ||
| // then passes each of those batches to the [yield] function. | ||
| func BySize[T any](in []T, maxSize int, encode func(T) ([]byte, error), yield func([][]byte) error) error { |
Tang8330
reviewed
Jun 17, 2024
| } | ||
| { | ||
| // Non-empty slice + all items exactly fit into just under one batch: | ||
| batches, err := testBySize([]string{"foo", "bar", "baz", "qux"}, 13, goodEncoder) |
There was a problem hiding this comment.
Worth adding a check on how many times goodEncoding was called? Which will test how many times yield was called
There was a problem hiding this comment.
In this case goodEncoder will be called once for each item (4 times) but yield will be called once. The amount of times that yield is called will always equal the length of batches.
Tang8330
approved these changes
Jun 17, 2024
danafallon
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.