Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Transfer leverages an in-memory database that is key-value based.
The key being the primary key(s) of the table and the value is the latest row as we leverage Kafka for ordering guarantee.
Problem
The problem is that if there are 2 events within one flush cycle say:
When we flush, we'll only have the latest deleted row. Our merge logic for handling soft deletes was incorrect as it wrongfully assumed that the row should be in the target table.
We fixed this by changing
WHEN NOT MATCHED AND IFNULL(foo.__ARTIE_DELETE, false) = false
to beWHEN NOT MATCHED