Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bigquery] Move encodeStructToJSONString function #742

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

nathan-artie
Copy link
Contributor

@nathan-artie nathan-artie commented Jun 18, 2024

Also remove a couple unused constants.

@nathan-artie nathan-artie marked this pull request as draft June 18, 2024 18:29
@nathan-artie nathan-artie marked this pull request as ready for review June 18, 2024 18:31
// Structs from relational and Mongo are different.
// MongoDB will return the native objects back such as `map[string]any{"hello": "world"}`
// Relational will return a string representation of the struct such as `{"hello": "world"}`
func encodeStructToJSONString(value any) (string, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to this function.

@nathan-artie nathan-artie merged commit 0d9b908 into master Jun 18, 2024
1 check passed
@nathan-artie nathan-artie deleted the nv/move-func branch June 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants