-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush rules to be cognizant of in-memory database size #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will confirm this alleviates the REQUEST ENTITY error from Snowflake. |
Tang8330
changed the title
WIP - Enhance our flush rules
Flush rules to be cognizant of in-memory database size
May 8, 2023
FYI @TamasNo1 - this is now officially supported. |
Amazing, well done @Tang8330 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #68
This is necessary because Snowflake and BigQuery both have their limits on how big (in kb) a request can be. Snowflake's API docs specify 1 MB src...but the actual limit is significantly higher.
Through this PR, I've tested 25 mb payloads without any issue. However, this does happen...especially for tables with TOAST columns. The current workaround is to just reduce the number of items from the
bufferRow
but that's not robust.This PR will allow users to specify an additional merge rule, and our merge rules will now look like:
Whichever one is invoked first will trigger a flush cycle.
TODOs: