Fix py 3.10 test errors

artigraph · Nov 17, 2021 · 3af2c3a · 3af2c3a
1 parent f0d8af0
commit 3af2c3a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/arti/internal/type_hints.py b/src/arti/internal/type_hints.py
@@ -57,6 +57,7 @@ def lenient_issubclass(klass: Any, class_or_tuple: Union[type, tuple[type, ...]]
     if isinstance(class_or_tuple, tuple):
         return any(lenient_issubclass(klass, subtype) for subtype in class_or_tuple)
     check_type = class_or_tuple
+    # NOTE: py 3.10 supports issubclass with Unions (eg: `issubclass(str, str | int)`)
     if is_union_hint(check_type):
         return any(lenient_issubclass(klass, subtype) for subtype in get_args(check_type))
     return _check_issubclass(klass, check_type)
@@ -120,7 +121,7 @@ def signature(
 # Focusing on  3.9+ (for now)
 
 
-if sys.version_info < (3, 10):
+if sys.version_info < (3, 10):  # pragma: no cover
 
     def is_union(type_: Any) -> bool:
         return type_ is Union

diff --git a/tests/arti/internal/test_type_hints.py b/tests/arti/internal/test_type_hints.py
@@ -79,7 +79,7 @@ def test_lenient_issubclass_false(
 
 def test_lenient_issubclass_error_cases() -> None:
     assert not lenient_issubclass(5, 5)  # type: ignore
-    with pytest.raises(TypeError, match="arg 2 must be a class or tuple of classes"):
+    with pytest.raises(TypeError, match="arg 2 must be a class"):
         lenient_issubclass(tuple, 5)  # type: ignore