Feature/socketio acknowledgements #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone care to comment on this? Is it appropriate? |
|
Apologies @Demostrike, haven't had the time to review new PRs yet. Thanks, and I'll try to get it reviewed soon. |
|
No worries @hassy, just want to make sure on if it can be included as a contribution. Would love to see it or a similar option or acknowledgments in the release for use. |
|
Would love to see this! Was just about to have a crack myself. |
|
Oh and @Demostrike, I have a comment, this is brilliant. Thankyou. I've been using it for the last month. |
|
Thanks @Demostrike! (& @plumpNation as well for extensive testing :) There will be an Artillery release later this week which will include this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to test emit acknowledgements in artillery.io as per the socket.io spec.
Reuses code for comparisons/matches where possible.