You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# action version
artilleryio/action-cli@v1 (`a7d844f999d5f3603f104db9cafb981d74f02940`)
# pulled image by action
artilleryio/artillery:latest (`sha256:e084b9aae46a8aca4ed50aaa2750ca2a72a51672b7fbd3544896da0ceeadbc6e`)
Running this command:
# on GHA
run-fargate ... --tags env:dev,service:artilleryio,target_stack:my-app
I expected to see this happen:
To see the run-fargate job logs output the tags
The fargate task and downstream resources to be tagged with the respective tags
Instead, this happened:
The job logs did emit the tags, but
The fargate task and downstream resources were not tagged
Additional Context
These tasks are running on a pre-existing untagged cluster, but the lack of tags there is fine for us, as we mainly want to distinguish between different artillery test runs on the same cluster using tags.
Thoughts
A very brief look at some of the source seems to point to context.tags being correctly picked up by artillery, hence the job logs emitting the relevant tags
Version info:
Running this command:
I expected to see this happen:
run-fargate
job logs output the tagsInstead, this happened:
Additional Context
These tasks are running on a pre-existing untagged cluster, but the lack of tags there is fine for us, as we mainly want to distinguish between different artillery test runs on the same cluster using tags.
Thoughts
A very brief look at some of the source seems to point to
context.tags
being correctly picked up by artillery, hence the job logs emitting the relevant tagsartillery/packages/artillery/lib/platform/aws-ecs/legacy/run-cluster.js
Lines 636 to 639 in af8834b
but not being passed to the created AWS resources here
artillery/packages/artillery/lib/platform/aws-ecs/legacy/run-cluster.js
Lines 1590 to 1602 in af8834b
or here
artillery/packages/artillery/lib/platform/aws-ecs/legacy/run-cluster.js
Lines 1634 to 1660 in af8834b
The text was updated successfully, but these errors were encountered: