Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script fails when image URLs have the same suffix #3

Closed
tkaufmann opened this issue Aug 14, 2020 · 2 comments
Closed

Script fails when image URLs have the same suffix #3

tkaufmann opened this issue Aug 14, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@tkaufmann
Copy link

I tend to share images publicy on my nextcloud. They get their own preview webpage on links like

https://nextcloud/s/xj3DQpSJXgzsA2x

and can be downloaded/inserted into markdown files by appending '/preview'

https://nextcloud/s/xj3DQpSJXgzsA2x/preview

Unfortunately markdown_images_downloader will download all images as preview.ext, overwriting the same file again and again.
@artiomn artiomn added the bug Something isn't working label Sep 8, 2020
artiomn added a commit that referenced this issue Sep 9, 2020
@artiomn
#3 Bug was fixed, dedup added
54ef3df
@artiomn
Copy link
Owner

artiomn commented Sep 9, 2020

Fixed.

@artiomn artiomn closed this as completed Sep 9, 2020
@tkaufmann
Copy link
Author

That's a nice solution, learned something for my own programming skills. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkaufmann @artiomn