Timeout TTL set incorrectly

[telkins]

I'm new to this package, so take what I say with a grain of salt. I could be wrong. 🤓

I installed the latest/greatest today and tried it out a bit in the hopes of getting a better overall understanding of the leaky bucket and how it would look/feel for my particular use case.

Basically, I was finding that whenever I would seem to fill my bucket, it would be empty again...right away. 😳

It took a while of debugging/troubleshooting, which helped me learn a bit more of the ins/outs of the package and the concept in general, but I believe I found a problem.

There appears to be an issue in ArtisanSdk\RateLimiter\Limiter:

    public function timeout(int $duration = 1): void
    {
        if ($this->hasTimeout()) {
            return;
        }

        $this->cache->put(
            $this->getTimeoutKey(),
            (int) $this->lastBucket()->timer() + ($duration * 60),
            $duration
        );
    }

The problem appears to be in the call to put(). The ttl is never multiplied by 60, so it expires long before the timeout would expire. I believe $duration should be multiplied by 60 for the ttl as well.

I'll try to do a quick PR and relate it to this issue. I'll test it locally first, of course. 🤓

Please let me know if you have any questions.

[dalabarge]

The $duration is set in minutes while it should/could be set in seconds. So line (int) $this->lastBucket()->timer() + ($duration * 60) becomes just (int) ($this->lastBucket()->timer() + $duration) as the cache will then work on Laravel 6+ as $duration will now be specified in seconds. Just sweep the code for references to timing and make sure they are all specified in seconds and that should fix things.

[dalabarge]

Tag released 1.0.0-rc3 is compatible with specifying timeout() and duration() in seconds instead of minutes.