Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section vertical padding and Disable Top / Bottom Spacing #29

Closed
chrisvidal opened this issue Jan 30, 2023 · 3 comments
Closed

Section vertical padding and Disable Top / Bottom Spacing #29

chrisvidal opened this issue Jan 30, 2023 · 3 comments

Comments

@chrisvidal
Copy link
Contributor

Section vertical padding and Disable Top / Bottom Spacing is not working properly in general over the different pages and possibility.
For instance, the partial events and products does not handle the disable options and in general the section HTML tag does not have any vertical padding, so the options disable does not do anything.

I will try to submit a general submit for that matter.
@chrisvidal
Copy link
Contributor Author

My idea is to add a global setting to choose the default vertical padding for a section.
Then user can disable top and / or bottom section by section if he wants to with the existing options

@artistro08
Copy link
Owner

@chrisvidal That was my initial plan. I'll work on adding that now.

@artistro08
Copy link
Owner

Fixed in the 5.0 Release.

Planned release date is today.

artistro08 added a commit that referenced this issue Feb 4, 2023
@artistro08
Fixes #29 and builds on #44
f1f9780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisvidal @artistro08