Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Shape.PointSequence type to int64 from unit32 #21

Merged
merged 1 commit into from May 2, 2023
Merged

Change Shape.PointSequence type to int64 from unit32 #21

merged 1 commit into from May 2, 2023

Conversation

captchanjack
Copy link
Contributor

Fixes #20

@artonge
Copy link
Owner

artonge commented Apr 17, 2023 •
edited

Looks good, while you're at it, could you check if Pathway.TraversalTime and Frequency.HeadwaySeconds are working correctly? They are also using uint32, so I am wondering if this is causing an issue there too. Not sure why I used uint32 in the first place.

@captchanjack
Copy link
Contributor Author

My dataset doesn't have those fields! Do you want me to change them to int64 anyway?
image

@artonge
Copy link
Owner

artonge commented May 2, 2023

Let's keep it like that for now :)

@artonge artonge merged commit 2a290b6 into artonge:master May 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shape Sequence has the wrong type
2 participants
@captchanjack @artonge