Do not fail tests ultimately after first test error #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging, @artsok. Do you already have plans for a new release on Maven Central including this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @artsok,
I tried to fix the issue #8 with this pull request. The solution was inspired by @mkobit's solution described in https://stackoverflow.com/a/46207476. More precisely, I changed the repetition logic to abort a failed test rather than failing it as long as there are enough repetitions left that allow to reach the
minSuccesscount.Moreover, I needed to do a bit of refactoring and tried to run the tests programmatically instead of manually (by removing the
@Disabledannotation).I am looking forward to your feedback and hope to get the feature released as soon as possible as it it is crucial for any CI/CD automation.
Best regards