Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Update to Akka 2.5, add CI #21

Merged
merged 6 commits into from
May 3, 2017
Merged

Update to Akka 2.5, add CI #21

merged 6 commits into from
May 3, 2017

Conversation

bhoggard
Copy link
Contributor

@bhoggard bhoggard commented May 1, 2017

Since we use TravisCI for a number of our open source projects, I started setting it up. I will test on my branch until I get the automatic pushes to Maven Central.

.travis.yml Outdated
- 2.11.11
notifications:
slack:
secure: QcJzLxkSVl91qQnHD/DalJN2QuXcb2ac8V/mCb8TkzbB0fVX15o1M9JV8JHnIT0asjiNxrzne5CP/7jfnI3coQIuVkOlBV0gViLI1UO74G0wXij6Z2s+XhCaLfPiwlrE22NoipOtAC6aLMZ0EYbWw6vMCqQuXTi7QDqQKpCOgPks4/wbwi07AvxiBDBPBZXiciw7dkT0WDBM+XxhjvINTvgT9CuaQwSnLLBRwu0JjhVeaBTssx0kB85FyGhyrDq4N/36TsdJJRfGVOH20WXPQ8jqw0Vmnt3TkYaw8QTdIE1s2owio0xmrMkKpaWp/PJ1RQBFHLg7NmgjwOUby0YdYeg11OwhPIx7YfcPHrJon5QNPYc00ti7h4HEg3+vX/uPbi9P7RC/gYYM39p4OhNmfzs9azEMIKHRvz0m7r4QMKgTwUNdpLVm4+BgHk0Y2skNy+Nv5W6bH4Y5FbV/DjiK72XBq5N0s7mH2bM3bhOorUc4keXL5SxNCqbNjW+0cRiMjOxk1r63X7jlxO9UPQMBth6VZ2l+gCz/8iw/CPhXo1Qmzc0P5a8RD+sQVIbKDfrbnufC1AF659CSefrGRRKmUsnhjHexpA6/a5kCjGPYGbt6fgK/BwIi+eRjWP2q5IS1YZhJjG1hxtFXlrMU8WcPkHof42q34dhOgTBMIOsPc6I=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how this works, but should this be committed?

Copy link
Contributor Author

@bhoggard bhoggard May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says "secure" because it's encrypted with a key connected to our specific repo. It's safe to have it in an open-source repo.


organization := "net.artsy"

homepage := Some(url("https://github.com/artsy/atomic-store"))

licenses +=("MIT", url("https://opensource.org/licenses/MIT"))

scalaVersion := "2.11.8"
scalaVersion := "2.11.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can definitely wait, but I wonder if we should be cross-building for 2.12 too. It seems pretty simple, but don't really know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add that to the matrix.

build.sbt Outdated
"org.iq80.leveldb" % "leveldb" % "0.7", // For LevelDB journal
"org.scalatest" %% "scalatest" % "3.0.1" % "test",
"org.scalacheck" %% "scalacheck" % "1.13.4" % "test", // Property-based testing
"org.iq80.leveldb" % "leveldb" % "0.9", // For LevelDB journal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need this at all. I think we can do without.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can decide that. I'm not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm....let's remove it. It's a different storage backend than we actually use, and I'm almost positive everything will work just fine without it.

@acjay
Copy link
Contributor

acjay commented May 3, 2017

Checkmarks! 🙌

@bhoggard bhoggard merged commit 48bee49 into artsy:development May 3, 2017
@bhoggard bhoggard deleted the akka25 branch May 3, 2017 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants