Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-publish steps to emit types #19

Merged
merged 3 commits into from
Apr 21, 2020
Merged

update pre-publish steps to emit types #19

merged 3 commits into from
Apr 21, 2020

Conversation

eessex
Copy link
Contributor

@eessex eessex commented Apr 21, 2020

Related thread: https://artsy.slack.com/archives/CP9P4KR35/p1587482069305700

Updates types to emit on pre-publish

📦 Published PR as canary version: 0.2.1-canary.19.337.0

✨ Test out this PR locally via:

npm install @artsy/cohesion@0.2.1-canary.19.337.0
# or 
yarn add @artsy/cohesion@0.2.1-canary.19.337.0

package.json Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One q about the omission of test files from the type-checker, but otherwise LGTM 👍 Merge when ready.

@eessex eessex merged commit f54a133 into master Apr 21, 2020
@artsyit
Copy link
Collaborator

artsyit commented Apr 21, 2020

🚀 PR was released in v0.2.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants