Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove module resolver #20

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Remove module resolver #20

merged 1 commit into from
Apr 21, 2020

Conversation

eessex
Copy link
Contributor

@eessex eessex commented Apr 21, 2020

Babel's module resolver was not interpreting paths correctly in consuming apps. This updates to remove the plugin and config, and use relative paths throughout.

πŸ“¦ Published PR as canary version: 0.2.2-canary.20.352.0

✨ Test out this PR locally via:

npm install @artsy/cohesion@0.2.2-canary.20.352.0
# or 
yarn add @artsy/cohesion@0.2.2-canary.20.352.0

@eessex eessex requested a review from dblandin April 21, 2020 21:30
@artsy-peril artsy-peril bot added the Version: Patch A deploy for bug fixes or minor changes label Apr 21, 2020
Copy link
Member

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this locally with the canary version. Nice work! πŸ’― πŸ’œ

@damassi damassi merged commit e2a0792 into master Apr 21, 2020
@damassi damassi deleted the type-emit branch April 21, 2020 21:42
@artsyit
Copy link
Collaborator

artsyit commented Apr 21, 2020

πŸš€ PR was released in v0.2.2 πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Version: Patch A deploy for bug fixes or minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants