Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AS-4453] Adding description to event View Work #494

Merged
merged 1 commit into from Apr 26, 2024
Merged

[AS-4453] Adding description to event View Work #494

merged 1 commit into from Apr 26, 2024

Conversation

daytavares
Copy link
Contributor

@daytavares daytavares commented Apr 26, 2024 •
edited by jira bot

The type of this PR is: Feature

This PR resolves [EMI-1829]

Description

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

@daytavares daytavares self-assigned this Apr 26, 2024
@artsy-peril artsy-peril bot added Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features labels Apr 26, 2024
@daytavares daytavares requested a review from MrSltun April 26, 2024 09:43
MrSltun
MrSltun approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@MrSltun MrSltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨

@daytavares daytavares merged commit 5fb3804 into main Apr 26, 2024
6 checks passed
@daytavares daytavares deleted the dtavares_add_description branch April 26, 2024 10:08
@artsyit
Copy link
Collaborator

artsyit commented Apr 26, 2024

🚀 PR was released in v4.176.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSltun MrSltun MrSltun approved these changes

Assignees

@daytavares daytavares

Labels
Jira Synced Indicates that Peril has connected this PR to Jira released Version: Minor A deploy for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daytavares @artsyit @MrSltun