This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
@alloy => Manual CC Entry Problem 📱 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested for real/device? |
|
I've not tested it on a device yet; will do after lunch. |
|
(Thanks for the reminder!) |
|
Alrighty then, I’ll wait to hear when you tested it on device. Regarding splitting off PRs, I’m ok with this personally. If you feel wrong and it would keep you up at night you could just do the fix and then a new PR with all the ‘UI’ issues you came across. |
|
Separate PRs are hard since sometimes the fixes I do depend on the other code I've already changed for the main issue. Gonna keep it like this, in small commits 👍 |
|
@ashfurrow To be clear, I meant that I’m personally ok with not splitting off, i.e. as-is. |
ashfurrow
changed the title
|
@alloy verified on device. |
|
💯 👍 |
|
Oh, forgot to notice before, but CHANGELOG? |
|
Knew there was something I was forgetting. |
|
💯 +1 👍 |
alloy
added a commit
that referenced
this pull request
Jun 29, 2015
@alloy => Manual CC Entry Problem 📱
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crus is that we weren't sending a "complete" event to our
finishedSignalonce the CC tokenization succeeded. I added tests to ensure that the event is sent if and only if the tokenization succeeds.I also noticed a few other problems that I fixed and added test for, in separate commits. Should I make things like that separate PRs? Open to advice.
(Note: Circle and Travis are currently both failing to run tests. I've checked that they pass locally.)
Fixes #455.