Skip to content

Commit

Permalink
chore(AMBER-769): Update sale message usage (#10440)
Browse files Browse the repository at this point in the history 
* Remove `Price on request` logic definitions

We don't need to perform special requests to render the `Price on
request` label anymore. When this label is needed, it will be returned
like that directly from Gravity.

* Update the tests according to the expected message

Not all of these updates are required for the test to pass, just trying
to keep the fixtures closer to the truth as possible

* Remove condition that hides sale message from the artwork grid

We do not want to hide the sale message for specific artworks.
Reverts the work done in 66eabf8
  • Loading branch information
@lidimayra
lidimayra committed Jun 28, 2024
1 parent 36a6120 commit 13e9326
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 35 deletions.
2 changes: 1 addition & 1 deletion src/app/Components/ArtworkGrids/ArtworkGridItem.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ describe("ArtworkGridItem", () => {
const artwork = {
title: "Some Kind of Dinosaur",
date: "2015",
saleMessage: "Contact for price",
saleMessage: "Price on request",
sale: {
isAuction: true,
isClosed: true,
Expand Down
8 changes: 0 additions & 8 deletions src/app/Components/ArtworkGrids/ArtworkGridItem.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -554,14 +554,6 @@ export const saleMessageOrBidInfo = ({
return `${currentBid} (${numberOfBidsString})`
}

if (artwork.saleMessage === "Contact for price") {
return "Price on request"
}

if (artwork.saleMessage === "Inquire about availability") {
return ""
}

return artwork.saleMessage
}

Expand Down
4 changes: 2 additions & 2 deletions ...s/Sections/ArticleSectionImageCollection/__tests__/ArticleSectionArtworkCaption.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe("ArticleSectionArtworkCaption", () => {
expect(screen.getByText("Test Artwork, 2023")).toBeOnTheScreen()
expect(screen.getByText("Test Partner")).toBeOnTheScreen()
expect(screen.getByText("Test Artist")).toBeOnTheScreen()
expect(screen.getByText("Contact for price")).toBeOnTheScreen()
expect(screen.getByText("Price on request")).toBeOnTheScreen()
})

it("navigates", async () => {
Expand All @@ -51,5 +51,5 @@ const artwork = {
},
date: "2023",
artists: [{ name: "Test Artist", href: "artist-href" }],
saleMessage: "Contact for price",
saleMessage: "Price on request",
}
2 changes: 1 addition & 1 deletion src/app/Scenes/Inbox/Components/Conversations/ItemArtwork.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe("ItemArtworkFragmentContainer", () => {
image: {
thumbnailUrl: "https://testthumbnail",
},
saleMessage: "Contact for price",
saleMessage: "Price on request",
}),
})

Expand Down
4 changes: 1 addition & 3 deletions src/app/Scenes/Inbox/Components/Conversations/ItemArtwork.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ export const ItemArtwork: React.FC<ItemArtworkProps> = ({ artwork }) => {
</Text>
)}
<Text variant="sm" numberOfLines={1}>
{artwork.saleMessage === "Contact for price"
? "Price on request"
: artwork.saleMessage}
{artwork.saleMessage}
</Text>
</Flex>
</Flex>
Expand Down
2 changes: 1 addition & 1 deletion src/app/Scenes/MyCollection/Screens/ArtworkForm/MyCollectionArtworkForm.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ const mockArtworkSearchResult = {
},
title: "Morons",
date: "2007",
saleMessage: "Contact for price",
saleMessage: "Price on request",
internalID: "61897c11ae2e33000dc95088",
artistNames: "Banksy",
href: "/artwork/banksy-morons-unsigned-16",
Expand Down
2 changes: 1 addition & 1 deletion src/app/Scenes/Sale/BuyNowArtworksRail.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const saleArtworksConnectionEdges = new Array(10).fill({
id: "artwork-id",
title: "Best artwork ever",
date: "2019",
saleMessage: "Contact for price",
saleMessage: "Price on request",
artistNames: "Banksy",
href: "/artwork/artwroks-href",
image: {
Expand Down
2 changes: 1 addition & 1 deletion src/app/Scenes/Sale/Components/NewBuyNowArtworksRail.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const artworksConnectionEdges = new Array(10).fill({
id: "artwork-id",
title: "Best artwork ever",
date: "2019",
saleMessage: "Contact for price",
saleMessage: "Price on request",
artistNames: "Banksy",
href: "/artwork/artwroks-href",
image: {
Expand Down
2 changes: 1 addition & 1 deletion src/app/Scenes/Sale/SaleArtworksRail.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const saleArtworkNode = {
url: "artworkImageUrl",
},
href: "/artwork/artwroks-href",
saleMessage: "Contact for price",
saleMessage: "Price on request",
artistNames: "Banksy",
slug: "artwork-slug",
internalID: "Internal-ID",
Expand Down
2 changes: 1 addition & 1 deletion src/app/Scenes/Sale/SaleLotsList.tests.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ const saleArtworkNode = {
url: "artworkImageUrl",
},
href: "/artwork/artwroks-href",
saleMessage: "Contact for price",
saleMessage: "Price on request",
artistNames: "Banksy",
slug: "artwork-slug",
internalID: "Internal-ID",
Expand Down
30 changes: 15 additions & 15 deletions src/app/__fixtures__/ArtworkFixture.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export const ArtworkFixture = {
},
title: "Untitled",
date: "1990-2014",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -169,7 +169,7 @@ export const ArtworkFixture = {
},
title: "Snow No. 12",
date: "2002",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -198,7 +198,7 @@ export const ArtworkFixture = {
},
title: "Snow No. 2",
date: "2002",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -227,7 +227,7 @@ export const ArtworkFixture = {
},
title: "Snow No. 34",
date: "2002",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -256,7 +256,7 @@ export const ArtworkFixture = {
},
title: "Road Series 30",
date: "2007",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -285,7 +285,7 @@ export const ArtworkFixture = {
},
title: "Road Series 2",
date: "2007",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -314,7 +314,7 @@ export const ArtworkFixture = {
},
title: "Snow No. 31",
date: "2002",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -343,7 +343,7 @@ export const ArtworkFixture = {
},
title: "Snow No. 3",
date: "2002",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -382,7 +382,7 @@ export const ArtworkFixture = {
},
title: "Smoke",
date: "2008",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -411,7 +411,7 @@ export const ArtworkFixture = {
},
title: "Untitled",
date: "2014",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -440,7 +440,7 @@ export const ArtworkFixture = {
},
title: "Extraordinary",
date: "2017",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -498,7 +498,7 @@ export const ArtworkFixture = {
},
title: "Untitled",
date: "2014",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -527,7 +527,7 @@ export const ArtworkFixture = {
},
title: "Fashion",
date: "2010-2016",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -556,7 +556,7 @@ export const ArtworkFixture = {
},
title: "Horses",
date: "2002",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down Expand Up @@ -585,7 +585,7 @@ export const ArtworkFixture = {
},
title: "Artery",
date: "2009",
sale_message: "Contact for price",
sale_message: "Price on request",
is_in_auction: false,
is_biddable: false,
is_acquireable: false,
Expand Down

0 comments on commit 13e9326

Please sign in to comment.