remove check for setTabLayouts (#5469)

artsy · Sep 17, 2021 · bc06e9f · bc06e9f
1 parent 1005897
commit bc06e9f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/src/palette/elements/Tabs/ContentTabs.tsx b/src/palette/elements/Tabs/ContentTabs.tsx
@@ -20,13 +20,9 @@ export const ContentTabs: React.FC<TabsProps> = ({ onTabPress, activeTab, tabs }
             onLayout={(e) => {
               const layout = e.nativeEvent.layout
               setTabLayouts((layouts) => {
-                // update layouts only once per tab
                 const result = layouts.slice(0)
-                if (!result[index]) {
-                  result[index] = layout
-                  return result
-                }
-                return layouts
+                result[index] = layout
+                return result
               })
             }}
             onPress={() => {

diff --git a/src/palette/elements/Tabs/NavigationalTabs.tsx b/src/palette/elements/Tabs/NavigationalTabs.tsx
@@ -27,13 +27,9 @@ export const NavigationalTabs: React.FC<TabsProps> = ({ onTabPress, activeTab, t
               onLayout={(e) => {
                 const layout = e.nativeEvent.layout
                 setTabLayouts((layouts) => {
-                  // update layouts only once per tab
                   const result = layouts.slice(0)
-                  if (!result[index]) {
-                    result[index] = layout
-                    return result
-                  }
-                  return layouts
+                  result[index] = layout
+                  return result
                 })
               }}
             />

diff --git a/src/palette/elements/Tabs/StepTabs.tsx b/src/palette/elements/Tabs/StepTabs.tsx
@@ -33,13 +33,9 @@ export const StepTabs: React.FC<TabsProps> = ({ onTabPress, activeTab, tabs }) =
               onLayout={(e) => {
                 const layout = e.nativeEvent.layout
                 setTabLayouts((layouts) => {
-                  // update layouts only once per tab
                   const result = layouts.slice(0)
-                  if (!result[index]) {
-                    result[index] = layout
-                    return result
-                  }
-                  return layouts
+                  result[index] = layout
+                  return result
                 })
               }}
             >