Reachability overlay isn’t removed when connection works again

[alloy]

I just got into a state where the “Could Not Reach Artsy” alert was laid over the window, but once the connection came back it was never removed. I could still change tabs and see that the app worked.

We have 1 review from a user that might be about this issue:

Never "connects" to Internet
The one and only message I get consistently is that Artsy cannot connect to the Internet. No way that resolve it. Besides, it is a false message anyway.

I didn’t find any steps yet to reproduce it, but hopefully looking at the code will shed enough light on this.

[katarinabatina]

Yup I am getting it every time I tap the heart

[alloy]

Apparently you are supposed to tap the overlay and will go away. Not sure if I had tried that and it stayed on screen or not.

In any case, it’s not very clear what action the user is supposed to take. Why don’t we use a normal alert view for this?

[katarinabatina]

The overlay could be removed but no content ever loaded.

Katarina

On Jul 13, 2015, at 7:30 AM, Eloy Durán notifications@github.com wrote:

Apparently you are supposed to tap the overlay and will go away. Not sure if I had tried that and it stayed on screen or not.

In any case, it’s not very clear what action the user is supposed to take. Why don’t we use a normal alert view for this?

—
Reply to this email directly or view it on GitHub.

[alloy]

@katarinabatina What about removing this pseudo alert view completely and replace it with a normal iOS alert with an OK button? It makes it clear how to dismiss the alert, that it’s completely dismissed before doing anything else with the app, and any future (and now) layout issues (#615).

[katarinabatina]

if we were able to cache data so there was something to look at, I would probably prefer going with a more minimal banner that just says
"no internet connection" but I dont think we're close to having offline caching yet correct?

[alloy]

if we were able to cache data so there was something to look at

I think that in most cases where this view is shown, there actually is content being shown, it’s just that the last action you wanted to perform didn’t succeed due to connection issues. It’s also just as dismissible as any other alert, just slightly prettier, but with the downside that people don’t necessarily know it’s an alert or that they have to tap it.

In case there’s no connection and no content loaded yet (on app launch) the other view is shown instead: #624 (comment)

but I dont think we're close to having offline caching yet correct?

Nope.

[alloy]

Moving to #644.