-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add My Collection artwork form location autocomplete #10227
feat: Add My Collection artwork form location autocomplete #10227
Conversation
4d82b09
to
1014a0a
Compare
@@ -232,6 +232,12 @@ export const ArtworkMetaProps = graphql` | |||
} | |||
artistNames | |||
category | |||
collectorLocation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Remove artworkLocation
from the query.
@@ -313,6 +315,7 @@ export const MyCollectionArtworkFormMain: React.FC< | |||
<Flex p={2}> | |||
<Join separator={<Spacer y={2} />}> | |||
<ArtistField /> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃檹
4b0bbf1
to
efd7868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! sorry I missed this during the review
馃敶 Do not merge before https://github.com/artsy/gravity/pull/17722 has run
This PR resolves ONYX-860
Description
This replaces the My Collection form location input component with a new autocomplete input component.
It is still possible to not select any of the suggestions and store an arbitrary string as a location. This string then gets saved as the "city", which can be displayed correctly in the web and app.
PR Checklist
To the reviewers 馃憖
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.