feat(AMBER-665): Bring PA Artwork Details to parity with designs and mweb #10278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyfromseattle
changed the title
jpotts244
reviewed
May 22, 2024
src/app/Scenes/Artwork/Artwork.tsx
Outdated
| }) | ||
| if (!!artworkBelowTheFold?.isEligibleForArtsyGuarantee) { | ||
| sections.push({ | ||
| key: "artsyGuarantee", |
There was a problem hiding this comment.
Though they shouldnt render at the same time, could there be any clashes here now that we have two keys with the name "artsyGuarantee"?
(I wonder if this is what we are running into in that failing spec? 馃 )
There was a problem hiding this comment.
Ooooooh just saw this
There was a problem hiding this comment.
don't think it should be an issue as only one is pushed at a time
jpotts244
reviewed
May 22, 2024
| @@ -557,7 +556,7 @@ describe("Artwork", () => { | |||
| }) | |||
|
|
|||
| describe("Artsy Guarantee section", () => { | |||
| it("should be displayed when eligible for artsy guarantee", async () => { | |||
| fit("should be displayed when eligible for artsy guarantee", async () => { | |||
There was a problem hiding this comment.
Let's remove this fit, I think there are more failures in here!
Maybe they can provide us some clues
damassi
added
the
Squash On Green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves AMBER-665
Description
This PR brings the mobile artwork page to parity with web and the PA designs. I went over everything with Peter and he confirmed he is happy with the page. I also fixed some small bugs (Read more truncating wrong, price field rendering twice).
To the reviewers 馃憖
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.