[CSGN-225] Choose the destination of artist consign taps based on your active tab #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
damassi
reviewed
Jun 3, 2020
|
|
||
| RCT_EXPORT_METHOD(getSelectedTabName:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject) | ||
| { | ||
| return self.getSelectedTabName(resolve, reject); |
damassi
reviewed
Jun 3, 2020
| @@ -17,6 +18,7 @@ export interface ArtistConsignButtonProps { | |||
| export const ArtistConsignButton: React.FC<ArtistConsignButtonProps> = props => { | |||
| const tracking = useTracking() | |||
| const buttonRef = useRef() | |||
| const selectedTabName = useSelectedTabName() | |||
damassi
approved these changes
Jun 3, 2020
There was a problem hiding this comment.
Crazy impressive PR @pepopowitz 💯 Everything is very clear and straightforward and was able to follow along nicely 👍 No substantive feedback from here.
brainbicycle
reviewed
Jun 4, 2020
| default: | ||
| return @"Unknown"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Yeah I don't think there is a much better solution with objective-C/C enums seems fine to me.
brainbicycle
approved these changes
Jun 4, 2020
ds300
reviewed
Jun 4, 2020
…selected tab If you're on the sell tab, we'll push a new page onto your nav stack; everywhere else, we'll send you to the sell tab landing page.
pepopowitz
force-pushed
the
csgn-225-conditional-nav-for-artist-consign-button
branch
from
21de9a9
to
3d1758f
Compare
pepopowitz
commented
Jun 4, 2020
pepopowitz
changed the title
jonallured
approved these changes
Jun 4, 2020
| @@ -286,6 +287,10 @@ - (void)updateRoutes | |||
| return [[ARNavigationController alloc] initWithRootViewController:submissionVC]; | |||
| }]; | |||
|
|
|||
| [self.routes addRoute:@"/collections/my-collection/marketing-landing" handler:JLRouteParams { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work depends on #3400. The only commits in this diff that are related to this PR are the last two.
Addresses https://artsyproduct.atlassian.net/browse/CSGN-225
This PR uses your currently selected tab to determine where to send you when you tap the artist consign button.
For users who are on the home or search tab (or anywhere that isn't sell), we'll continue to send them to the sell tab landing page:
If you're already in the sell tab, we push another landing page view onto your nav stack. This addresses the experience of tapping on something and not getting enough feedback about where you're going:
#trivial (but not really; it's just covered by another entry that's already in the changelog.)