Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android rn screen crash #5062

Merged
merged 4 commits into from
Jun 30, 2021
Merged

Conversation

brainbicycle
Copy link
Contributor

@brainbicycle brainbicycle commented Jun 29, 2021

The type of this PR is: fix

This PR resolves CX-1660

Description

There is a known issue in rn-screens that causes a crash when restoring the application from background in release builds, this is the recommended fix: software-mansion/react-native-screens#17 (comment)

Tested locally, I'll test once this goes live in a beta and follow-up with a hot fix if all goes okay.

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

  • Fixes a crash when opening app from background - brian

Dev changes

@MounirDhahri
Copy link
Member

Thank you for following up on that!

@MounirDhahri MounirDhahri merged commit 62b1bbe into master Jun 30, 2021
@MounirDhahri MounirDhahri deleted the brian/android-rn-screen-crash branch June 30, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android crashes nondeterministically when restoring from background
2 participants