Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FX-3255): disabled options cannot clicked #5388

Merged
merged 3 commits into from Sep 3, 2021
Merged

fix(FX-3255): disabled options cannot clicked #5388

merged 3 commits into from Sep 3, 2021

Conversation

dimatretyak
Copy link
Contributor

@dimatretyak dimatretyak commented Sep 3, 2021 •
edited

The type of this PR is: Bugfix

This PR resolves FX-3255

Description

Previously, it was possible to select a filter option that was disabled (there were only visual changes). This bug is fixed in this PR and the user cannot click on the disabled element

Demo

Before

screencast.2021-09-02.14-50-10.mp4

After

screencast.2021-09-03.14-18-42.mp4

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a changelog entry below or my changes do not require one.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Disabled filter options cannot clicked - dimatretyak

iOS user-facing changes

Android user-facing changes

Dev changes

@dimatretyak dimatretyak self-assigned this Sep 3, 2021
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 3, 2021 •
edited

This PR contains the following changes:

  • Cross-platform user-facing changes (Disabled filter options cannot clicked - dimatretyak)

Generated by 🚫 dangerJS against b4faa01

dblandin
dblandin approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@dblandin dblandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💯

@dblandin
Copy link
Member

dblandin commented Sep 3, 2021

Dev changes (Disabled filter options cannot clicked - dimatretyak)

This seems like user-facing fix to me so we might want to move the changelog entry to "Cross-platform user-facing changes"

@dimatretyak
Copy link
Contributor Author

Dev changes (Disabled filter options cannot clicked - dimatretyak)

This seems like user-facing fix to me so we might want to move the changelog entry to "Cross-platform user-facing changes"

Done

@dimatretyak dimatretyak merged commit ce56fa1 into master Sep 3, 2021
@dimatretyak dimatretyak deleted the dimatretyak/fix/disabled-options-cannot-clicked branch September 3, 2021 16:23
Gon4ar5 pushed a commit that referenced this pull request Oct 27, 2021
@dimatretyak
fix(FX-3255): disabled options cannot clicked (#5388)
43e3204 
* fix: disabled option cannot be clicked

* test: use testing-library

* chore: updated podfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblandin dblandin dblandin approved these changes

@iskounen iskounen Awaiting requested review from iskounen

Assignees

@dimatretyak dimatretyak

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dimatretyak @ArtsyOpenSource @dblandin