Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: re-enable all tests in OnboardingSocialPick.tests.tsx #5999

Merged
merged 1 commit into from Jan 10, 2022

Conversation

pvinis
Copy link
Contributor

@pvinis pvinis commented Jan 10, 2022

The type of this PR is: tests

This PR resolves []

Description

A quick PR because I saw this in the tests.

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

#nochangelog

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against 6fb0946

@dariakoko
Copy link
Contributor

Thanks for spotting this!

@dariakoko dariakoko merged commit e5c8410 into main Jan 10, 2022
@dariakoko dariakoko deleted the pvinis-patch-9 branch January 10, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants