Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style:line width 100 #6073

Merged
merged 3 commits into from Jan 21, 2022
Merged

style:line width 100 #6073

merged 3 commits into from Jan 21, 2022

Conversation

patrinoua
Copy link
Contributor

@patrinoua patrinoua commented Jan 21, 2022

The type of this PR is: style
This PR resolves adding as a style line width of 100

Poll: https://artsy.slack.com/archives/C02BAQ5K7/p1642522846027100

Description

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have tested my changes on iOS and Android.
  • I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
  • I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

ⓘ 'User-facing' changes will be published as release notes.

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (Rename modal title - patrinoua)

Generated by 🚫 dangerJS against e53c269

@@ -315,7 +315,7 @@
]
},
"prettier": {
"printWidth": 120,
"printWidth": 100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 120

@pvinis pvinis merged commit 5225c11 into main Jan 21, 2022
@pvinis pvinis deleted the patrinoua/line-width-100 branch January 21, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants