Update rubocop from 0.47.1 to 0.60.0 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dleve123
commented
Nov 6, 2018
dleve123
commented
- Addresses CVE-2017-8418
- Re-generates .rubocop_todo.yml to skip failing style validations
|
Danger run resulted in 2 warnings; to find out more, see the checks page. Generated by 🚫 dangerJS |
Here's an example of a CHANGELOG.md entry: * [#28](https://github.com/artsy/estella/pull/28): Update rubocop from 0.47.1 to 0.60.0 - [@dleve123](https://github.com/dleve123).Generated by 🚫 Danger |
|
Interesting build failure - looks like it's related to Elasticsearch API updates. We probably need to freeze the |
dblock
reviewed
Nov 8, 2018
* run a `rubocop -a` and commit all automatically generated style changes
dleve123
force-pushed
the
update-rubocop
branch
from
3885615
to
9ac5f8c
Compare
* elasticsearch-models's 2.X series supports Elasticsearch 2.X. + See [elasticsearch-model's README][0] for more info [0]:https://github.com/elastic/elasticsearch-rails/tree/4429fd9c27b4808a721e90481fd8814a0b7486d4/elasticsearch-model#compatibility
|
@dblock @cavvia – this PR should be good to go. There's no meaningful diff to the project, so I'm not sure what Coveralls is complaining about. LMK if there's anything else needed to get this merged. FWIW: rubocop is a development dependency, so there is no additional upstream systems that need to get patched here. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.