Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Garner 0.4.0 (a.k.a 1.0.0-alpha) #28

Merged
merged 33 commits into from
Jun 11, 2013

Conversation

fancyremarker
Copy link
Contributor

Whole lotta changes here. I'd recommend starting by reading the upgrade notes, and then moving on to the README, followed by the actual code.

The goals were:

Frank Macreery added 30 commits May 17, 2013 09:56
…itly finding and fetching a Mongoid::Document
@ghost ghost assigned dblock Jun 11, 2013
@fancyremarker
Copy link
Contributor Author

Oh, forgot to add: this pull request includes only the (simpler) CacheKey key strategy and Touch invalidation strategy. I'll submit a somewhat more advanced IdentityIndex key strategy and accompanying IdentityIndexInvalidation strategy as a separate pull request, as a demonstration of how to add a new strategy pair. Then we can benchmark the two formally.

0.4.0 (TBD)
-----------

* Complete rewrite of Garner. See [UPGRADING](UPGRADING.md) for details on how to upgrade from Garner 0.3.3 and earlier versions - [@macreery](https://github.com/macreery).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would list a succinct, high level, list of the changes from this pull request.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I just link to the UPGRADING.md? Seems more relevant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Actually, as a compromise, how about if I individually list each of the resolved bugs, along with a more concise version of the bullet points in this pull request's message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, IMO, thx.

@dblock
Copy link
Contributor

dblock commented Jun 11, 2013

This is some seriously awesome work, Mr. @macreery. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants