-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed Garner 0.4.0 (a.k.a 1.0.0-alpha) #28
Conversation
…some more methods
…nd some other integration specs
…ongoid::Document and Mongoid::Identity
…itly finding and fetching a Mongoid::Document
Oh, forgot to add: this pull request includes only the (simpler) |
0.4.0 (TBD) | ||
----------- | ||
|
||
* Complete rewrite of Garner. See [UPGRADING](UPGRADING.md) for details on how to upgrade from Garner 0.3.3 and earlier versions - [@macreery](https://github.com/macreery). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would list a succinct, high level, list of the changes from this pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I just link to the UPGRADING.md? Seems more relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: Actually, as a compromise, how about if I individually list each of the resolved bugs, along with a more concise version of the bullet points in this pull request's message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better, IMO, thx.
This is some seriously awesome work, Mr. @macreery. Merging. |
Proposed Garner 0.4.0 (a.k.a 1.0.0-alpha)
Whole lotta changes here. I'd recommend starting by reading the upgrade notes, and then moving on to the README, followed by the actual code.
The goals were:
garnered_find
class method with automatically appropriate key and binding #24 are all fixed here.garner-mongoid
gem; that should be straightforward from here.Rack::ConditionalGet
andRack::ETag