Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Horizon for latest Hokusai; add error-reporting #23

Merged
merged 2 commits into from Apr 5, 2019

Conversation

joeyAghion
Copy link
Collaborator

There were a number of recent changes to the output and behavior of hokusai registry images, so I had to update releasecop to accommodate the new formatting here: joeyAghion/releasecop@57ee7ae

This PR upgrades releasecop to take advantage of these fixes for hokusai v0.5.4.

Also, the whole cron step that checks each project has proven to be very brittle since it depends on specific project configurations and external tools like git and hokusai which occasionally change or break. This updates the cron to recover from errors during each check step, store the error (if any), and render it on the front end for greater visibility. It looks like:

Screen Shot 2019-04-04 at 11 15 30 PM

(error message is visible if you hover over the icon). And:

Screen Shot 2019-04-04 at 11 16 13 PM

Copy link
Contributor

@ashkan18 ashkan18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!! Thanks!

@ashkan18 ashkan18 merged commit ae70179 into artsy:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants