update causality schema #2867
Merged
update causality schema #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsirius
reviewed
Dec 4, 2020
| @@ -236,7 +236,7 @@ type Query { | |||
| ): LotStandingConnection! | |||
|
|
|||
| "Returns an increment policy with specific `id`." | |||
| incrementPolicy(id: String!): IncrementPolicy | |||
| incrementPolicy(id: ID!): IncrementPolicy | |||
There was a problem hiding this comment.
These are not showing up in the resulting MP schema updates above. I think it's because they are not permitted when merging schemas. But let me know if I am wrong.
|
Merging! I think from the MP perspective, it's just a description update. We'll see client updates submitted automatically shortly, e.g. Force, Eigen, and Volt. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to https://github.com/artsy/causality/pull/861 (already in staging, not production) which fixed some
ID-typed args that had been changed toStrings. I don't think we are currently using any of these argument-containing fields in metaphysics.Please let me know if this isn't the right way to go about this schema upgrade 馃