Pass original_session_id to oauth provider if available (PLATFORM-2978) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starsirius
reviewed
Mar 10, 2021
| @@ -31,6 +31,16 @@ def self.configure | |||
| def raw_info | |||
| @raw_info ||= access_token.get('/api/current_user', headers: { 'X-ACCESS-TOKEN' => access_token.token }).parsed | |||
| end | |||
|
|
|||
| alias old_request_phase request_phase | |||
There was a problem hiding this comment.
TIL you can do it with an alias. Is it effectively the same as calling super?
There was a problem hiding this comment.
I'm not 100% sure and was following examples for this.
I think they can be a little different. E.g., super might refer to the base class's implementation (OmniAuth::Strategies::OAuth2 in this case), while an alias would refer to whatever self.request_phase resolves to at the time alias is called. Since the Artsy strategy can itself be extended, I thought it was safer to stick with this.
starsirius
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like the API to be able to associate users' original sessions with backend account activity. This PR introduces support for an optional
original_session_idparameter to certain authentication actions. Backend support is being added in https://github.com/artsy/gravity/pull/13895.(This deserves a test but I couldn't get one to work after struggling for 1+ hours, so submitting this anyway.)
https://artsyproduct.atlassian.net/browse/PLATFORM-2978