Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Configuring
artsy_api_url
inOmniAuth::Artsy
doesn't changesite
inOmniAuth::Strategies::Artsy
.Solution
This is because of the fact that
option
method inStrategies::Artsy
was called at load time and when we configureOmniAuth::Artsy
it's too late and doesn't impact how strategy was setup. Not sure what's the best solution here, but I ended up:option
call inOmniAuth::Strategies::Artsy
toconfigure
method and call it once during load time for existing users of this gem.reconfigure_strategy
method toOmniAuth::Artsy
which will be called after runningconfigure
block and will callconfigure
method mentioned ☝️