feat: add new input component #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
MounirDhahri
requested review from
nickskalkin,
MrSltun,
olerichter00 and
dariakoko
MounirDhahri
force-pushed
the
feat/add-new-input-component
branch
3 times, most recently
from
4c74087
to
03e9b9d
Compare
dariakoko
approved these changes
Apr 19, 2024
src/elements/Input/Input.tsx
Outdated
Comment on lines
211
to
213
| // if (value) { | ||
| // return HORIZONTAL_PADDING | ||
| // } |
MounirDhahri
force-pushed
the
feat/add-new-input-component
branch
from
cbfb1e4
to
8bd0441
Compare
MounirDhahri
changed the title
|
I will merge this now and both related Energy and Eigen PRs 🚀 We did QA as a team and I will flag this to the release captain to do further QA with Applause |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the new input component to Palette.
I apologize for the not-so-granular commits, I was working on Eigen initially See artsy/eigen#9997
Notes
Screenshots from the updates stories
** Screenshots from the app**
📦 Published PR as canary version:
13.2.2--canary.207.1945.0✨ Test out this PR locally via:
npm install @artsy/palette-mobile@13.2.2--canary.207.1945.0 # or yarn add @artsy/palette-mobile@13.2.2--canary.207.1945.0