fix(APPL-872): return null if Collapse is not opened #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: George <g.kartalis7@gmail.com> Co-authored-by: Brian Beckerle <49686530+brainbicycle@users.noreply.github.com>
artsy-peril
bot
added
Jira Synced
gkartalis
approved these changes
Apr 17, 2024
|
just a heads up to onyx this seems to work fine but does make the transition a bit jumpy. It fixes the worse issue of hidden elements displaying and causing the app to become unresponsive though. |
|
🚀 PR was released in |
|
Thanks for the fix! I will look into this again, because we've made a change to this component to not unmount the content when it's collapsed. This change was supposed to keep the state when going back to a previous step in the SWA flow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves APPL-872
Description
This PR updates the Collapse element to not render a view when the Collapse is not opened
cc @artsy/onyx-devs