feat(a11y): Add accessibility label on popover #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkartalis
commented
Apr 18, 2024
| @@ -58,7 +58,7 @@ export const Popover = ({ | |||
| <Flex flexDirection="row" justifyContent="space-between" alignItems="center"> | |||
| {title ? title : <Flex />} | |||
| {!noCloseIcon && ( | |||
| <Touchable onPress={onDismiss}> | |||
| <Touchable onPress={onDismiss} accessibilityRole="button" aria-label="Dismiss popover"> | |||
There was a problem hiding this comment.
this is the change, the rest were formatted by the linter
MrSltun
approved these changes
Apr 18, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Adds a11y label to the dismiss popover icon.
Reasoning: need to be able to select the dismiss icon on e2e tests