Remove separator from pagination component #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a shared part of the component
|
👍 |
|
merge on green |
|
Deploy preview for artsy-palette ready! Built with commit 5b0ed40 |
|
🚀 PR was released in v2.36.0 🚀 |
|
Deploy preview for artsy-palette ready! Built with commit 87a0a29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I migrated
LargePaginationfrom Reaction to Palette, I brought with it a separator component that is used in Force but not in Volt. I have put the separator component back in Reaction and removed it from Palette so that it doesn't become a part of the shared component library.