Change the color of Chevron icon #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for artsy-palette ready! Built with commit 9b6ea49 |
|
Hmm what kind of alignment issues were you seeing when trying to resize the chrevron? I tried adding |
|
oh when we did it, we noticed a weird alignment between the checkmark in previous steps and the chevron icon. currently they are vertically aligned properly. Does yours look good with |
|
Looks fine to me when just specifying
Mind if I push to your branch before merging? |
|
your version looks great! yes please 🙌 |
|
🚀 PR was released in v4.7.3 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://artsyproduct.atlassian.net/browse/PURCHASE-982, looks like the color of these icons are slightly brighter than what we currently have, changed it to
black30with @lilyfromseattle.We also tried to change the size to make it little smaller to match that design but making it smaller would actually cause some small alignment issues so we didn't do that part.