Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignee shouldn't be required for Deploy PRs #122

Open
dleve123 opened this issue May 23, 2019 · 1 comment
Open

Assignee shouldn't be required for Deploy PRs #122

dleve123 opened this issue May 23, 2019 · 1 comment

Comments

@dleve123
Copy link
Contributor

Proposal:

Disable the Peril rule requiring that there be an assignee for deployment PRs (PRs from master -> release)

Reasoning

A deployment PR isn't an artifact that should require review - in repositories where we have PR-based deployments, we are just leveraging the CI hooks related to PRs to drive an automated deploy. So in this case, the Peril warning isn't needed, so it should be removed.

Exceptions:

I don't think there should be any?

Additional Context:

Here's an example PR demonstrating the problem: https://github.com/artsy/candela/pull/187

@ashfurrow
Copy link
Contributor

Yeah, seems uncontroversial. Let's do it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants