New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offer stepper to Shipping/Payment/Review #1510
Conversation
@@ -128,141 +128,3 @@ describe("Offer InitialMutation", () => { | |||
}) | |||
}) | |||
}) | |||
|
|||
// import { Button } from "@artsy/palette" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ashkan18 this looked unused-- is there a need to keep it around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry, you mean the whole test section? yes 👍 can be removed since it seems same as above!
Deploy preview for artsy-reaction ready! Built with commit f8682f1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 💯 Will give @ashkan18 a chance to respond about the commented out tests before merging.
This PR updates the
shipping
,payment
, andreview
steps to pass in the ordermode
and determine whether or not to show the "Offer" stepper for those views.Addresses: https://artsyproduct.atlassian.net/browse/PURCHASE-638