Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add offer stepper to Shipping/Payment/Review #1510

Merged
merged 8 commits into from Nov 8, 2018

Conversation

sweir27
Copy link
Contributor

@sweir27 sweir27 commented Nov 7, 2018

This PR updates the shipping, payment, and review steps to pass in the order mode and determine whether or not to show the "Offer" stepper for those views.

Addresses: https://artsyproduct.atlassian.net/browse/PURCHASE-638

@@ -128,141 +128,3 @@ describe("Offer InitialMutation", () => {
})
})
})

// import { Button } from "@artsy/palette"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ashkan18 this looked unused-- is there a need to keep it around?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, you mean the whole test section? yes 👍 can be removed since it seems same as above!

@artsyit
Copy link
Contributor

artsyit commented Nov 7, 2018

Deploy preview for artsy-reaction ready!

Built with commit f8682f1

https://deploy-preview-1510--artsy-reaction.netlify.com

Copy link
Contributor

@ds300 ds300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯 Will give @ashkan18 a chance to respond about the commented out tests before merging.

@sweir27 sweir27 merged commit 1ae4367 into artsy:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants