Add query-less merchandisable search preview #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Hicks <steven.j.hicks@gmail.com>
peril-staging
bot
added
the
Version: Patch
|
Deploy preview for artsy-reaction ready! Built with commit cebcfdd |
Co-authored-by: Jon Allured <jon.allured@gmail.com>
Co-authored-by: Jon Allured <jon.allured@gmail.com>
pepopowitz
changed the title
# Conflicts: # src/Components/Search/Previews/index.tsx
pepopowitz
changed the title
mzikherman
reviewed
Feb 8, 2019
| } | ||
| } | ||
| `} | ||
| render={renderWithLoadProgress( |
There was a problem hiding this comment.
Nice use of the helper method.
|
Looks perfect to me! |
|
🚀 PR was released in v12.1.31 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://artsyproduct.atlassian.net/browse/DISCO-725.
A collaboration 👯♂️with @jonallured!
This adds an auto-suggest preview for merchandisable artworks with no suggestion selected. It looks like this:
This doesn't match the zeplin prototypes exactly. We kept the visual faffing-about to a minimum while we waited for them to be completed. We can circle back to match them if/when they are done!
There are no tests, but there isn't a whole lot of trickery in these components. We can add a snapshot if we feel it's helpful, but probably won't unless someone asks for it.