Link header badges to Auction Result / Career Highlights #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsy-peril
bot
added
Jira Synced
Version: Patch
zephraph
added
Version: Minor
|
Looks good! I played w/ it on storybooks too. 👍 |
Codecov Report
@@ Coverage Diff @@
## master #3200 +/- ##
========================================
+ Coverage 82.4% 82.4% +<.1%
========================================
Files 761 761
Lines 11349 11349
Branches 2245 2245
========================================
+ Hits 9356 9357 +1
+ Misses 1383 1381 -2
- Partials 610 611 +1 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PURCHASE-1782
User experience feedback: The new labels Highest auction result and Career Stage feel/look tappable – could also lead users to Auction Result / Career Highlights?
I updated the indicators so that the auction record indicator links to the auction results tab, and the career stage indicator links to the cv page.