Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Consignments] Update ArtistConsignButton with targetSupply check #3364

Merged
merged 2 commits into from Apr 8, 2020
Merged

[Consignments] Update ArtistConsignButton with targetSupply check #3364

merged 2 commits into from Apr 8, 2020

Conversation

damassi
Copy link
Member

@damassi damassi commented Apr 8, 2020 •
edited

Addresses https://artsyproduct.atlassian.net/browse/CSGN-91
Depends on artsy/metaphysics#2284

Updates the Consign button with new isTargetSupply check.

Web:

Screen Shot 2020-04-08 at 12 43 30 PM

Mobile:

Screen Shot 2020-04-08 at 12 45 11 PM

@damassi damassi requested a review from jonallured April 8, 2020 07:33
@artsy-peril artsy-peril bot added the Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes label Apr 8, 2020
@damassi damassi added Version: Minor Indicates that this PR should have a minor deploy, usually for new features and removed Version: Patch Indicates that this PR should have a patch deploy, usually for bug fixes labels Apr 8, 2020
@damassi damassi mentioned this pull request Apr 8, 2020
Merged
jonallured
jonallured reviewed Apr 8, 2020
View reviewed changes
Copy link
Member

@jonallured jonallured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have what might be a naive question about the relationship between this code on web and iOS - would love some feedback on how we think about this stuff!! ❤️

src/Apps/Artist/Components/ArtistConsignButton.tsx Outdated Show resolved Hide resolved
pepopowitz
pepopowitz approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Reassigning to you to merge after you make the design updates you mentioned.

@pepopowitz pepopowitz assigned damassi and unassigned pepopowitz Apr 8, 2020
@damassi damassi merged commit 39f5528 into artsy:master Apr 8, 2020
@damassi damassi deleted the add-target-supply-button branch April 8, 2020 19:56
@artsyit
Copy link
Contributor

artsyit commented Apr 8, 2020

🚀 PR was released in v26.8.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonallured jonallured jonallured left review comments

@pepopowitz pepopowitz pepopowitz approved these changes

Assignees

@damassi damassi

Labels
Merge On Green released Version: Minor Indicates that this PR should have a minor deploy, usually for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damassi @artsyit @jonallured @pepopowitz