Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"in the 18th century" becomes "in the 19th century" #76

Open
BergFulton opened this issue Feb 20, 2015 · 5 comments
Open

"in the 18th century" becomes "in the 19th century" #76

BergFulton opened this issue Feb 20, 2015 · 5 comments

Comments

@BergFulton
Copy link

IRN 1011438
Action: Adding party with ownership date "in the 18th century"
Expectation: "in the 18th century"
Reality: Date changes to "in the 19th century"

It appears that it adds a century, so to get the appropriate one, you've got to aim one down. Standard date weirdness?

@workergnome
Copy link
Contributor

nope.  A bad bug.  I’ll fix it on Monday.


David Newbury
(773) 547-2272
david.newbury@gmail.com

On Fri, Feb 20, 2015 at 12:59 PM, Tracey Berg-Fulton
notifications@github.com wrote:

IRN 1011438
Action: Adding party with ownership date "in the 18th century"
Expectation: "in the 18th century"
Reality: Date changes to "in the 19th century"

It appears that it adds a century, so to get the appropriate one, you've got to aim one down. Standard date weirdness?

Reply to this email directly or view it on GitHub:
#76

@BergFulton
Copy link
Author

If it helps-
It's oddly specific. If there's something before "in the xy century", the date doesn't change. So
"1500 until the 18th century" works fine with no change.

"until the 18th century" will change to "until the 19th century".

@workergnome
Copy link
Contributor

That does help, actually.  I’ll write a test for it and fix it.


David Newbury
(773) 547-2272
david.newbury@gmail.com

On Fri, Feb 20, 2015 at 1:06 PM, Tracey Berg-Fulton
notifications@github.com wrote:

If it helps-
It's oddly specific. If there's something before "in the xy century", the date doesn't change. So
"1500 until the 18th century" works fine with no change.

"until the 18th century" will change to "until the 19th century".

Reply to this email directly or view it on GitHub:
#76 (comment)

@workergnome
Copy link
Contributor

Can you provide the exact line that’s causing issues, with what you’re trying to say with it?  I’m trying to figure out how “in the 19th century” fits into a provenance records.


David Newbury
(773) 547-2272
david.newbury@gmail.com

On Fri, Feb 20, 2015 at 1:06 PM, Tracey Berg-Fulton
notifications@github.com wrote:

If it helps-
It's oddly specific. If there's something before "in the xy century", the date doesn't change. So
"1500 until the 18th century" works fine with no change.

"until the 18th century" will change to "until the 19th century".

Reply to this email directly or view it on GitHub:
#76 (comment)

@BergFulton
Copy link
Author

My original intent was to write "Until sometime in the 18th century" but that converts to "in the 18th century". Then I found another bit of information and was able to add "1500 until the 18th century"

This is the record currently in KE:
"commissioned by Confraternity of St. Augustine, Perugia, Italy, 1500 until the 18th century"

When I noticed it happening, I just had "Confraternity of St. Augustine, Perugia, Italy, [until sometime] in the 18th century"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants