Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad buttons #10

Merged
merged 1 commit into from Jun 26, 2019
Merged

Pad buttons #10

merged 1 commit into from Jun 26, 2019

Conversation

dudeck
Copy link
Collaborator

@dudeck dudeck commented Jun 25, 2019 •
edited by artur-ios-dev

Closes #3

PabloPL
PabloPL suggested changes Jun 25, 2019
View reviewed changes
lib/models/pad_button_item.dart Outdated
final List<Gestures> supportedGestures;

const PadButtonItem(
{this.index,
Copy link

@PabloPL PabloPL Jun 25, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use @required + assert to indicate what parameters are required to work?
Something like

const PadButtonItem({
@required this.index,
}) : assert(index != null);

lib/views/circle_view.dart Outdated
this.boxShadow,
this.border,
this.buttonImage,
this.buttonText = ""});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comma here after "}" + reformat

lib/models/pad_button_item.dart Outdated
this.buttonImage,
this.backgroundColor = Colors.white54,
this.pressedColor = Colors.lightBlueAccent,
this.supportedGestures = const [Gestures.TAP]});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comma here after "}" + reformat

lib/views/pad_button_view.dart
final Color backgroundPadButtonsColor;

PadButtonsView({
this.size,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@required + assert

dudeck
dudeck commented Jun 25, 2019
View reviewed changes
Copy link
Collaborator Author

@dudeck dudeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PabloPL updated PR after your comments. Please rereview ;)

@dudeck dudeck force-pushed the pad_buttons branch 2 times, most recently from 9e1e282 to 406daba Compare June 25, 2019 14:54
@artur-ios-dev artur-ios-dev self-requested a review June 26, 2019 05:44
@artur-ios-dev artur-ios-dev merged commit fb3932c into artur-ios-dev:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloPL PabloPL PabloPL approved these changes

@artur-ios-dev artur-ios-dev artur-ios-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add ButtonsView
3 participants
@dudeck @PabloPL @artur-ios-dev