Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileProcessListener's should be loaded through a ServiceLoader #101

Closed
arturbosch opened this issue Jun 20, 2017 · 2 comments
Closed

FileProcessListener's should be loaded through a ServiceLoader #101

arturbosch opened this issue Jun 20, 2017 · 2 comments
Assignees
@arturbosch
Labels
core improvement
Milestone
RC1

Comments

@arturbosch
Copy link
Member

This would allow external jars to extend detekt with more metric collectors.

Idea: Like RuleSetLocator's loadProviders function. Maybe inside ProcessingSettings class.
@arturbosch arturbosch modified the milestone: 1.0.0 Jul 23, 2017
@arturbosch arturbosch removed the easy label Jul 25, 2017
@arturbosch arturbosch self-assigned this Jul 25, 2017
arturbosch added a commit that referenced this issue Jul 25, 2017
@arturbosch
Extract processor, notification and processor api to api module - #101
044dcff
arturbosch added a commit that referenced this issue Jul 25, 2017
@arturbosch
Load file processors and console-, output reports through a service l…
407d732 
…oader - #101
arturbosch added a commit that referenced this issue Jul 25, 2017
@arturbosch
Add detekt file processors to cli - #101
b815186 
Having core and cli provide processors, the meta-inf file gets overriden.
arturbosch added a commit that referenced this issue Jul 25, 2017
@arturbosch
Remove loading processors from cli - #101
5f2966c
@arturbosch arturbosch mentioned this issue Jul 28, 2017
Merged
@arturbosch arturbosch modified the milestones: 1.0.0, RC1 Jul 28, 2017
arturbosch added a commit that referenced this issue Jul 29, 2017
@arturbosch
Extract processor, notification and processor api to api module - #101
ff0a868
arturbosch added a commit that referenced this issue Jul 29, 2017
@arturbosch
Load file processors and console-, output reports through a service l…
720beb2 
…oader - #101
arturbosch added a commit that referenced this issue Jul 29, 2017
@arturbosch
Add detekt file processors to cli - #101
f2b15fd 
Having core and cli provide processors, the meta-inf file gets overriden.
arturbosch added a commit that referenced this issue Jul 29, 2017
@arturbosch
Remove loading processors from cli - #101
1bbb28c
@vanniktech
Copy link
Contributor

This can be closed now.

@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arturbosch arturbosch

Labels
core improvement
Projects
None yet
Milestone
RC1
Development

No branches or pull requests
2 participants
@vanniktech @arturbosch