DataClassContainsFunctions - allow conversion function

[vanniktech]

What do you think about an option that allows conversion functions that take the Data class and basically map it to a different type. For instance:

data class MySomething(val prop1: String, ...) {
  fun toSomething() = Something(prop1)
}

[schalkms]

Is this related to the UseDataClass rule?
Does that mean that a normal class which uses conversion functions should also be a data class candidate?

[vanniktech]

Hmm it might yeah. I'd say that conversion functions are defined with a prefix of to or as and then no arguments.

[arturbosch]

Actually I also often use conversion functions for data classes but outside the class and in the same file. I would also argue that this should be the preferred way.

[tagantroy]

@vanniktech @arturbosch Hello, should I add this feature to existing rules by default ( DataClassContainsFunctions, UseDataClass) or add additional configuration?

[arturbosch]

@tagantroy I don't know. I still think such functions should be put at top level (extension functions). If you guys ( @vanniktech @schalkms ) give the issue a thumbs up, then why not @tagantroy :)

[schalkms]

I agree with @arturbosch
I wouldn't add conversion functions to data classes. However, I also think an optional configuration is ok if it's set to false per default.

[arturbosch]

@tagantroy here you have your go :) thanks for contributing!

[tagantroy]

@arturbosch already merged, can we close it or mark as ready?

[Mauin]

Closed via #445

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.