HtmlOutputFormatTest tests assume Unix-style line endings #602
Labels
Milestone
Comments
|
Do you might opening a PR for this :) ? |
|
Adding .gitattributes or changing the test? |
|
.gitattributes please |
|
Thanks for the fix ! |
3flex
added a commit
to 3flex/detekt
that referenced
this issue
Jan 3, 2018
Appveyor uses `git config --global core.autocrlf input` by default. However this is not the default on Windows machines, meaning some tests that pass on Appveyor may not pass when checked out on a Windows machine if the tests are affected by a file's line endings. This causes issues like detekt#602 which could be picked up earlier.
arturbosch
pushed a commit
that referenced
this issue
Jan 8, 2018
Appveyor uses `git config --global core.autocrlf input` by default. However this is not the default on Windows machines, meaning some tests that pass on Appveyor may not pass when checked out on a Windows machine if the tests are affected by a file's line endings. This causes issues like #602 which could be picked up earlier.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
An example:
assertThat(result).startsWith("<!DOCTYPE html>\n<html lang=\"en\">")default-html-report-template.htmlis checked out on Windows with Windows-style line endings (per my system default), so the test fails.Recommend adding either a
.gitattributesfile explicitly specifying Unix-style line endings for these templates so they're checked out with Unix-style line endings on Windows, or changing the tests to remove the Unix-style line endings (I think the first option is best).The text was updated successfully, but these errors were encountered: