Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding excludeAnnotatedClasses to UseDataClass. #694

Closed
serj-lotutovici opened this issue Jan 15, 2018 · 3 comments
Closed

Consider adding excludeAnnotatedClasses to UseDataClass. #694

serj-lotutovici opened this issue Jan 15, 2018 · 3 comments

Comments

@serj-lotutovici
Copy link
Contributor

I found myself in need of an exclude because some classes that are more configuration that data, give these false positives. For example:

@Module
class MyModule(
    @get:Provides val someVal: SomeInterface, 
    @get:Provides val otherVal:SomeOtherInterface
)

I could just add a suppress here, but it seems wrong because an object of this class will never require an equals or hashCode.

@arturbosch
Copy link
Member

I hate annotation-driven-development :(

@Mauin
Copy link
Collaborator

Mauin commented Jan 16, 2018

This addition does make sense for the rule, though. Especially in Android we'll see quite a few of these annotated classes which don't need to be data classes.

@arturbosch arturbosch added this to the RC6-3 milestone Feb 1, 2018
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants